feat: find out performance issue with big tables of nodes #2332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR targets performance issues in tables with many nodes by introducing a new virtualized rendering approach and improving scroll-based chunk management.
- Introduces the useVirtualizedTbodies hook to render table bodies with spacer rows and active chunk elements.
- Updates the overscan count in the useScrollBasedChunks hook from 1 to 15 and adjusts the default pagination limit from 20 to 50.
- Refactors TableChunk to remove the isActive flag and conditionally render content based on visible row range.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/PaginatedTable/useVirtualizedTbodies.tsx | New hook for virtualized tbody rendering with calculated spacer rows. |
| src/components/PaginatedTable/useScrollBasedChunks.ts | Updates to overscan count and revised logic to return visible row range. |
| src/components/PaginatedTable/TableChunk.tsx | Refactor to remove isActive flag and filter content by visible range. |
| src/components/PaginatedTable/PaginatedTable.tsx | Integration of virtualized rendering and updated pagination limit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2193
CI Results
Test Status: ❌ FAILED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 83.63 MB | Main: 83.62 MB
Diff: +5.97 KB (0.01%)
ℹ️ CI Information